forked from Unity-Technologies/com.unity.netcode.gameobjects
-
Notifications
You must be signed in to change notification settings - Fork 0
Test branch #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Test branch #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction of stat:awaiting triage label since name changed to stat:awaiting-triage as well as adding a default stat:reply:needed
This PR builds on Unity-Technologies#2579 and updates link for API Reference in **Documentation~** folder so it's up to date
This PR focuses on fixing CI issues raised in Unity-Technologies#3303 and before. Specifically: 1. 2023.3 editor was removed from supported list since based on official info it transitioned into 6000 editor and 2023 editor (by itself) is not supported. The associated ticket was (MTT-11355) 2. In case of ubuntu and 2021 editor (MTT-11354) correct version of libssl is being installed 3. UTR command was corrected to use preinstalled UTR on the image instead of downloading it 4. Removed upm-ci project pack definition and converted Code Coverage test to use upm-pvp pack job 5. Simplifies some unnecessary CI commands 6. Added detailed comments regarding CI setup and commands 7. Created CI_README file which describes overall configuration structure. 8. For macOS devices we now use M1 model (Apple Silicon) in contrast to default x64 Intel Mac which introduced a lot of bit-flipping errors --------- Co-authored-by: NoelStephensUnity <[email protected]>
This PR focuses on fixing PVP errors related to PVP-151-1 "**_Public APIs should be documented_**" and all remaining PVP errors **present in pvpExceptions.json file** We have quite a lot of errors to address so this PR will be a collaborative effort. If anyone want's to add to it what we should do is: 1. Check errors present in pvpExceptions.json file (preferably under "PVP-150-1", choose some to fix 2. Address those errors and when making commit remove the fixed errors from pvpExceptions file The first commit of this PR is an example of how such process should look like In general [new CI implementation](Unity-Technologies#3193) will catch all new errors like this so all we need to do is fix the present ones. This PR **does not** focus on PVP present in gold profile but if capacity allows, those can also be addressed. **Error present in "PVP-41-1" is to be expected** so there is no need of fixing this one! Another thing is that we could ignore error related to missing APIs for RuntimeTests because those were made internal in 2.X version (that's why those errors are not popping by there). Those APIs are not user facing so we could just leave them (otherwise there is like 2000 more APIs to add) --------- Co-authored-by: Noel Stephens <[email protected]> Co-authored-by: Emma <[email protected]> Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com>
This PR adds a `NetworkManager.OnPreShutdown` callback that happens before the internal shutdown is done. This is to allow accessing any state that is cleaned up by the `NetworkManager` during shutdown, such as accessing dynamically spawned NetworkObjects. fix: Unity-Technologies#3145 close: Unity-Technologies#3145 ## Changelog - Added: The event NetworkManager.OnPreShutdown has been added which is called before the NetworkManager cleans up and shuts down. ## Testing and Documentation - A test has been added to ensure this is being called, and called before OnServerStopped. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> --------- Co-authored-by: Noel Stephens <[email protected]>
<!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> <!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") --> [MTTB-90](https://jira.unity3d.com/browse/MTTB-90) [MTTB-1131](https://jira.unity3d.com/browse/MTTB-1131) <!-- Add RFC link here if applicable. --> ## Changelog - Fixed: Correctly sync network transform using world space on spawn ## Testing and Documentation - No tests have been added. --------- Co-authored-by: Noel Stephens <[email protected]>
Adding missing changelog entry for PR-3358.
… (develop) (Unity-Technologies#3359) Wrench version update to 0.10.45 and recipes regeneration
…ld not be started because no valid OpenCL device could be found" error. (Unity-Technologies#3370) Backport of Unity-Technologies#3369 After switching from Intel macOS to Apple Silicon due to the common problem with bit-flipping on Intel macOS the WebGL build job started failing due to "Light baking could not be started because no valid OpenCL device could be found" error. We need to figure out if this can be fixed or how to proceed with it. * PR that switched macOS device --> [NGOv1.X](Unity-Technologies#3326), [NGOv2.X](Unity-Technologies#3329) The issue exists on both NGO branches (*develop* and *develop-2.0.0*) so the solution needs to be applied on both. For now I'm disabling this job and tracking it in MTT-11726
…3367) Adds a test replicating the bug fixed in Unity-Technologies#3361 Move the code to sync prefabs for late joining clients into the `NetcodeIntegrationTest` ## Changelog - Added: Test for Unity-Technologies#3361 ## Testing and Documentation - Adds Unit test <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> --------- Co-authored-by: Noel Stephens <[email protected]>
This PR updates CODEOWNERS file to mainly account for recent creation of netcode-qa group. The reasoning is: - @michalChrobot and @miniwolf were removed since they are part of @Unity-Technologies/netcode-qa group which was added - @fluong6 was removed since he's not focusing on NGO right now and we can lower the noise for him --------- Co-authored-by: Noel Stephens <[email protected]>
…ity-Technologies#3373) Adding the support to use a double delta time for NetworkTimeSystemTests. ## Changelog NA ## Testing and Documentation - Includes update to the `NetworkTimeSystemTests.CorrectAmountTicksTest` integration test. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. -->
…es#3194) <!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> <!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") --> <!-- Add RFC link here if applicable. --> Adding Github action that will auto-update labels on Issues. --------- Co-authored-by: Noel Stephens <[email protected]> Co-authored-by: michalChrobot <[email protected]> Co-authored-by: Michał Chrobot <[email protected]>
…es#3378) This PR corrects workflow name and corrects one of the parameter to check if this specific label is present versus checking that only those labels are present
…echnologies#3379) This is a quick PR to correct IF statement in our github action because with current state it was called (and failed) when PR was commented
…cision errors (Unity-Technologies#3352) This PR is a backport of Unity-Technologies#3351 Some changes were not included because those were already present on develop branch. All Android tests passed before merging Co-authored-by: Noel Stephens <[email protected]>
… be marked as "Stale" by automation (Unity-Technologies#3380) This quick PR add labels that can be assigned to issues to exclude them from being marked as stale as per https://github.com/actions/stale?tab=readme-ov-file#exempt-issue-labels. We don't want imported issues to get Stale and potentially automatically closed
…formation (Unity-Technologies#3384) This PR remove the error log when a state has no transition information associated with it. [MTTB-1153](https://jira.unity3d.com/browse/MTTB-1153) ## Changelog - Fixed: Issue where `NetworkAnimator` would log an error if there was no destination transition information. ## Testing and Documentation - No tests have been added. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport